Skip to content

chore: whole new penal code for a whole new MDT#19

Open
somefriggnidiot wants to merge 71 commits into
Everfall-Development:masterfrom
somefriggnidiot:mergeme
Open

chore: whole new penal code for a whole new MDT#19
somefriggnidiot wants to merge 71 commits into
Everfall-Development:masterfrom
somefriggnidiot:mergeme

Conversation

@somefriggnidiot

@somefriggnidiot somefriggnidiot commented Jun 16, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

This time in the proper repo.

Summary by CodeRabbit

  • Chores
    • Updated project configuration files.

@somefriggnidiot
Initial mapping to new format
a942172
@somefriggnidiot
Add modifiers to charges, example legalPrinciples
b5853ad
@somefriggnidiot
Convert charges to modifiers
4cbb720
@somefriggnidiot
Update EF MDT penal code JSON
0771975
@somefriggnidiot
Remove nonsensical modifier assignments
5da5c8a
@somefriggnidiot
Remove restitution modifier where fine amount too low
feccdef
@somefriggnidiot
Wording pass for offenses involving theft
6b77d05
@somefriggnidiot
Wording pass for offenses involving fraud or damage to property
34b80b7
@somefriggnidiot
Wording pass for offenses against public administration
324f7ab
@somefriggnidiot
Convert conspiracy to liability option
0dbdd26
@somefriggnidiot
Wording pass on offenses against public order
b22c09a
@somefriggnidiot
Wording pass on offenses against health and morals
1aa251c
@somefriggnidiot
Wording pass on offenses against public safety
806c984
@somefriggnidiot
Wording pass on offenses involving the operation of a vehicle
d8a9203
@somefriggnidiot
Wording pass on offenses involving the well-being of wildlife
65c794f
@somefriggnidiot
Wording pass on offenses against persons
358111e
@somefriggnidiot
Add analysis and csv
5491688
@somefriggnidiot
Clarify first degree murder principles
7f96710
@somefriggnidiot
Torture changes
a7457a1
@somefriggnidiot
Add tags, severity score to csv
9861f4a
@somefriggnidiot
Redo analsis
c2bec19
@somefriggnidiot
Add individual charge recommendations
ee8a822
@somefriggnidiot
Add review items to analysis
9348c93
@somefriggnidiot
Remove "sale" from manufacturing of firearm
57aa42b
@somefriggnidiot
Manual: Fix liability options
76a7518
@somefriggnidiot
Murder distinctions
bd5312d
@somefriggnidiot
A spinkle of attempteds
8431698
@somefriggnidiot
Marijuana charge changes
e9506b4
@somefriggnidiot
Assault rework
c5bc480
@somefriggnidiot
independent analysis
0d0ca36
@somefriggnidiot
Balancing pass on modifiers
deb03fa
@somefriggnidiot
Liabilities for Torture, Carjacking
9bc2bd0
@somefriggnidiot
Add degreeCode
e411c98
@somefriggnidiot
Add boat, dv penal codes
63d6827
@somefriggnidiot
Remove sourceCode, sourceTitle
df0f514
@somefriggnidiot
Assault modifiers
548c114
@somefriggnidiot
DV adjustment
345dc16
@somefriggnidiot
Vehicle theft modifiers
982e61d
@somefriggnidiot
Govt items modifiers
0bd7aad
@somefriggnidiot
Possession of stolen property modifiers
03c928b
@somefriggnidiot
Smuggling charges modifiers
2a2adcf
@somefriggnidiot
Fraud modifiers
d786f29
@somefriggnidiot
Public admin modifiers
d8d85a7
@somefriggnidiot
Public order modifiers
326dcb4
@somefriggnidiot
Health and morals modifiers
6925641
@somefriggnidiot
Public safety modifiers
0752812
@somefriggnidiot
Vehicle operation modifiers
796f549
@somefriggnidiot
Wildlife modifiers
2a4e700
@somefriggnidiot
Helper file regen
a2f11aa
@somefriggnidiot
On Release modifiers
654862d
@somefriggnidiot
liability option consistency
e7f46af
@somefriggnidiot
Add accessory to GTA charges
bf653e5
@somefriggnidiot
Remove inconsequential modifiers from reckless speeding
f097c43
@somefriggnidiot
Hide util files
b2e1132
@somefriggnidiot
Fix line endings
9d33a64
@coderabbitai

coderabbitai Bot commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 416f1367-021d-47cd-b7df-455478d1cf19

📥 Commits

Reviewing files that changed from the base of the PR and between af1491c and 9d33a64.

📒 Files selected for processing (2)
  • .gitignore
  • ef-mdt-penal-code.json
📝 Walkthrough

Walkthrough

A single line is added to .gitignore to exclude the util/ directory from Git tracking.

Changes

Gitignore Update

Layer / File(s) Summary
Add util/ ignore rule
.gitignore		 Adds util/ to .gitignore so all files under that directory are ignored by Git.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~1 minutes

Suggested reviewers

  • jellyton255

Poem

🐇 Hippity hoppity, what do we see?
A util/ folder, now wild and free!
Git shall not track it, not even a byte,
One line in .gitignore sets it all right.
The bunny hops onward, tidy and bright! 🌟

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title describes a penal code system overhaul, but the only file changed in this PR is .gitignore with a utility directory ignore rule added. Update the title to reflect the actual changes, such as 'chore: add util directory to .gitignore' or investigate if this PR contains the incorrect changeset.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jellyton255

jellyton255 commented Jun 30, 2026

Copy link
Copy Markdown
Member

No json + want proper types.

@somefriggnidiot

somefriggnidiot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

No json + want proper types.

This is already in live. Please open an issue against the current state for preferential refactor requests.

@jellyton255

jellyton255 commented Jun 30, 2026

Copy link
Copy Markdown
Member

Well, fix, and it'll be reimplemented with the PROPER implementation.

@jellyton255

jellyton255 commented Jun 30, 2026

Copy link
Copy Markdown
Member

This is a BLOCKER for main site implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@somefriggnidiot @jellyton255